Skip to content

[python] update eckit building#297

Merged
pmaciel merged 1 commit into
feature/eckit-geofrom
feature/updatePythonBuild
Jun 9, 2026
Merged

[python] update eckit building#297
pmaciel merged 1 commit into
feature/eckit-geofrom
feature/updatePythonBuild

Conversation

@tmi

@tmi tmi commented Jun 9, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Whats happening here:

  1. fixes the symlink to be non-recursive and point out to the correct files
  2. deletes the obsolete build_chain
  3. introduces a simplified setup.py, so that
    a) the right version of the wheel is determined
    b) the right eckitlib dependency is propagated
    c) the .so files are included
    d) the wheel is marked as binary despite not being compiled from python's pov
  4. updates the buildconfig to enable python and set correct install dirs

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-297

@tmi tmi force-pushed the feature/updatePythonBuild branch from b92e075 to 3daa373 Compare June 9, 2026 12:39
@pmaciel pmaciel force-pushed the feature/updatePythonBuild branch from 3daa373 to f83cffb Compare June 9, 2026 12:41
@tmi tmi marked this pull request as draft June 9, 2026 12:43
@tmi tmi force-pushed the feature/updatePythonBuild branch 2 times, most recently from 4839d62 to 9d0221d Compare June 9, 2026 12:51
@tmi tmi marked this pull request as ready for review June 9, 2026 12:52
@tmi tmi force-pushed the feature/updatePythonBuild branch from 9d0221d to 94eed88 Compare June 9, 2026 12:55
@tmi tmi force-pushed the feature/updatePythonBuild branch from 94eed88 to 1468cc3 Compare June 9, 2026 13:03
@tmi

tmi commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

wheels tested with https://github.com/ecmwf/python-develop-bundle/actions/runs/27208066364

seems to work:

$ uv pip install --prerelease=allow -i https://test.pypi.org/simple/ eckit==2.0.8.dev91
Using Python 3.14.3 environment at: venv
Resolved 9 packages in 167ms
Prepared 1 package in 362ms
Installed 2 packages in 13ms
 + eckit==2.0.8.dev91
 + eckitlib==2.0.8.dev91

$ uv run python
Python 3.14.3 (main, Feb  3 2026, 22:52:18) [Clang 21.1.4 ] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import eckit
>>>

@codecov-commenter

codecov-commenter commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.68%. Comparing base (63c5a2a) to head (1468cc3).
⚠️ Report is 1 commits behind head on feature/eckit-geo.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           feature/eckit-geo     #297      +/-   ##
=====================================================
- Coverage              66.69%   66.68%   -0.02%     
=====================================================
  Files                   1123     1123              
  Lines                  57983    57983              
  Branches                4423     4423              
=====================================================
- Hits                   38674    38664      -10     
- Misses                 19309    19319      +10

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pmaciel pmaciel merged commit 1468cc3 into feature/eckit-geo Jun 9, 2026
146 of 214 checks passed
@pmaciel pmaciel deleted the feature/updatePythonBuild branch June 9, 2026 13:44
@tmi tmi mentioned this pull request Jun 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmi @codecov-commenter @pmaciel