PLUME-37: Add param updated state tracking to model data#20
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #20 +/- ##
===========================================
+ Coverage 68.48% 69.11% +0.63%
===========================================
Files 78 78
Lines 3116 3180 +64
Branches 270 273 +3
===========================================
+ Hits 2134 2198 +64
Misses 982 982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dsarmany
reviewed
Jul 18, 2025
3aece32 to
c2849e0
Compare
antons-it
requested changes
Jul 29, 2025
antons-it
left a comment
Collaborator
There was a problem hiding this comment.
Many thanks for this PR! only very minor comments (to be discussed) - Cheers!
c2849e0 to
a990518
Compare
a990518 to
d42051e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR as draft to receive initial feedback but the API hasn't been tested with IFS yet.
This PR adds utility methods to the Plume model data to keep track of the update status of each parameter. This status can be queried by plugins to know whether the params they use have been updated since the last time they ran, helping to decide whether or what parts to run.
This development is meant instead of the alternative in this PR.
Contributor Declaration
By opening this pull request, I affirm the following: