fix(cloud): resolve unauthorized error in agent image provisioning#8292
fix(cloud): resolve unauthorized error in agent image provisioning#8292Dexploarer wants to merge 10 commits into
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
This reverts commit 6624b03.
LifeOps Benchmark —
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
LifeOps Benchmark —
|
…s with owner name
…ub.com/elizaOS/eliza into codex/mobile-cloud-login-control-plane
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
LifeOps Benchmark —
|
Docker resolves bare image names (e.g. "elizaos/eliza:latest") against
Docker Hub by default, where the Eliza agent image does not exist. This
caused "pull access denied" / "unauthorized" errors when the provisioning
daemon tried to pull images for new agent sandboxes.
Changes:
- Use containersEnv.defaultAgentImage() ("ghcr.io/elizaos/eliza:stable")
instead of hardcoded bare names in both provisioning paths:
- packages/cloud-api/eliza-app/provisioning-agent/route.ts
- packages/cloud-shared/.../eliza-app/provisioning.ts
- Skip docker login when registry credentials are not configured,
allowing anonymous public pulls from ghcr.io and Docker Hub:
- packages/cloud-shared/.../registry.ts
- packages/cloud-shared/.../docker-sandbox-provider.ts
- Add unit test verifying the canonical ghcr.io image is passed:
- packages/cloud-api/__tests__/provisioning-agent-default-image.test.ts
- Update existing provisioning test assertion to match new image:
- packages/cloud-shared/.../eliza-app/provisioning.test.ts
- Fix bare image references in mock data and type defaults:
- plugins/plugin-elizacloud/src/types/cloud.ts
- packages/test/cloud-mocks/src/control-plane/server.ts
- packages/test/cloud-mocks/src/control-plane/store.ts
- Add unit test for registry login skip behavior:
- packages/cloud-shared/.../registry.test.ts
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
LifeOps Benchmark —
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
❌ PR title does not match the required pattern. Please use one of these formats:
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
LifeOps Benchmark —
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
LifeOps Benchmark —
|
Summary
Verification
Notes