Skip to content

CXF 116818: Fix Acceptance Tests#962

Draft
d-bhola wants to merge 4 commits into
mainfrom
CXF-116818-fix-accep-test
Draft

CXF 116818: Fix Acceptance Tests#962
d-bhola wants to merge 4 commits into
mainfrom
CXF-116818-fix-accep-test

Conversation

@d-bhola

@d-bhola d-bhola commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

This pull request updates test configurations and improves error handling for Equinix Fabric resources. The main changes include adjustments to VLAN tags and metro codes in test cases to ensure consistency, enhancements to error messages for resource deletion, and improvements to route filter deletion handling.

Test configuration updates:

  • Updated VLAN tag values in multiple test files (resource_fabric_routing_protocol_acc_test.go, datasources_test.go, resource_test.go, connection_route_filter/resource_test.go, precision_time/resource_test.go) to ensure consistency and correctness across test scenarios. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Changed metro code values in test cases to align with updated requirements, such as switching from "SV" to "DC". [1] [2]

Test validation improvements:

  • Added assertions to check that the equinix_asn attribute is set in routing protocol tests, improving test coverage for ASN fields. [1] [2]

Error handling enhancements:

  • Improved error messages in the CheckConnectionDelete function to include the connection ID and error details, aiding debugging when resource deletion fails.
  • Enhanced the WaitForDeletion function for route filters to handle 4xx errors by explicitly returning the DEPROVISIONED state, making deletion handling more robust.

Code cleanup:

  • Removed unused code for setting the Equinix ASN in the routing protocol payload, as this is now handled elsewhere or is redundant.

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "CXF 116818: Fix Acceptance Tests". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@codecov

codecov Bot commented Oct 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.13%. Comparing base (408fffd) to head (e2f9cb6).
⚠️ Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
...sources/fabric/connection_route_filter/resource.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   54.78%   47.13%   -7.66%     
==========================================
  Files         239      242       +3     
  Lines       31424    32263     +839     
==========================================
- Hits        17217    15208    -2009     
- Misses      13502    16448    +2946     
+ Partials      705      607      -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant