CXF 116818: Fix Acceptance Tests#962
Draft
d-bhola wants to merge 4 commits into
Draft
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
- Coverage 54.78% 47.13% -7.66%
==========================================
Files 239 242 +3
Lines 31424 32263 +839
==========================================
- Hits 17217 15208 -2009
- Misses 13502 16448 +2946
+ Partials 705 607 -98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates test configurations and improves error handling for Equinix Fabric resources. The main changes include adjustments to VLAN tags and metro codes in test cases to ensure consistency, enhancements to error messages for resource deletion, and improvements to route filter deletion handling.
Test configuration updates:
resource_fabric_routing_protocol_acc_test.go,datasources_test.go,resource_test.go,connection_route_filter/resource_test.go,precision_time/resource_test.go) to ensure consistency and correctness across test scenarios. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Test validation improvements:
equinix_asnattribute is set in routing protocol tests, improving test coverage for ASN fields. [1] [2]Error handling enhancements:
CheckConnectionDeletefunction to include the connection ID and error details, aiding debugging when resource deletion fails.WaitForDeletionfunction for route filters to handle 4xx errors by explicitly returning the DEPROVISIONED state, making deletion handling more robust.Code cleanup: