Add script cancellation support#1119
Open
tpetsas wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
gum_script_cancel()API that allows graceful termination of a running script from another thread.Implementation details:
JS_SetInterruptHandler()) to poll a per-script cancellation flag (is_cancelled) protected by a recursive mutex.Isolate::TerminateExecution()directly and skip exceptions via a try-catch block.Key changes summary:
GumScriptInterfaceGRecMutexcancellation_mutexcleanup fromdestroy_context()tofinalize()to prevent use-after-clear during disposeLimitations:
Only interrupts JavaScript execution. If a script is blocked in native code (e.g., a
NativeFunctioncall or a blocking syscall), cancellation will take effect once control returns to the JS engine.To quickly test only the added unit tests, do the following:
QJS:
V8: