fix(middleware): parse Accept-Encoding values exactly#1104
Open
JinRudy wants to merge 1 commit into
Open
Conversation
- 精确匹配 Accept-Encoding 中的编码名称 - 拒绝 q=0 的压缩编码 - 添加编码匹配回归测试
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1069
Summary
Accept-Encodingtokens exactly instead of using substring matching.q=0as not acceptable.Testing
go test ./middleware -run TestMatchAcceptEncoding -count=1go test ./middlewarego test ./...HTTPS_PROXY=http://127.0.0.1:7897 HTTP_PROXY=http://127.0.0.1:7897 ALL_PROXY=http://127.0.0.1:7897 go run golang.org/x/tools/cmd/goimports@latest -w middleware/compress.go middleware/compress_test.gomake test