fix(ui): prevent commit status popup overflowing its row#38081
Merged
Conversation
The commit-status popup lays out each row as a flex container with a left
block (icon + status context) and a right block ("Details" link). The
pull-request view refactor dropped the old `.status-context { flex: 1 }`
rule, so the left block expanded to full width and pushed the "Details"
link onto a new line. Combined with the fixed 40px row height, the wrapped
line overflowed and overlapped the file header above it.
Let the left block fill the remaining space with `flex: 1; min-width: 0`
and add `min-width: 0` to `.status-context` so its existing gt-ellipsis
truncation works, keeping "Details" on the same row.
Assisted-by: Claude:claude-opus-4-8
lunny
approved these changes
Jun 11, 2026
wxiaoguang
reviewed
Jun 12, 2026
| flex-wrap: wrap; | ||
| } | ||
|
|
||
| .commit-status-item > .flex-text-block:first-child { |
Contributor
There was a problem hiding this comment.
Please avoid such fragile style. You won't be able to know what is .flex-text-block:first-child
wxiaoguang
approved these changes
Jun 13, 2026
wxiaoguang
left a comment
Contributor
There was a problem hiding this comment.
If it looks good to you, feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38079
Regression path
The layout previously had
.commit-status-item .status-context { flex: 1 },which let the context fill remaining space and ellipsize. That rule was
dropped in #37517 ("Refactor pull request view (5)") when the row markup
moved to nested
.flex-text-blockwrappers, so nothing constrained theleft block anymore.
After:
