fix(decoder): reuse original key nodes when decoding inline structs#882
Open
duseo wants to merge 2 commits into
Open
fix(decoder): reuse original key nodes when decoding inline structs#882duseo wants to merge 2 commits into
duseo wants to merge 2 commits into
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #882 +/- ##
==========================================
- Coverage 80.65% 80.59% -0.07%
==========================================
Files 22 22
Lines 6845 6859 +14
==========================================
+ Hits 5521 5528 +7
- Misses 905 909 +4
- Partials 419 422 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #844
The mapping built for inline structs used tokenless
StringNodekeys which resulted in the formatter getting empty output.Reuse the original key nodes from
keyToKeyNodeMapso that custom unmarshalers receive data for nested structs.mapNode.Valuesis then sorted so the order stays deterministic.Before submitting your PR, please confirm the following.