fix(printer): check Alias func instead of Anchor for alias token#886
Open
SAY-5 wants to merge 1 commit into
Open
fix(printer): check Alias func instead of Anchor for alias token#886SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 80.65% 80.65%
=======================================
Files 22 22
Lines 6845 6845
=======================================
Hits 5521 5521
Misses 905 905
Partials 419 419 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alias branch in
(*Printer).propertyguarded onp.Anchor != nilbut then calledp.Alias(). A printer that sets a customAnchorfunc while leavingAliasnil panics with a nil func call when it reaches an alias token, instead of falling through to the default property (issue #876). Switched the guard top.Alias != nilto match the equivalent case in thePreviousTypeswitch just above.