reject out-of-range minutes in timezone offset parsing#1336
Merged
Conversation
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
timestamp(...).getMinutes("+00:99"),getMinutes("-00:90"), or a signed minute such asgetMinutes("+05:-30").Cause:
timeZoneparses the minute field of a numeric±HH:MMoffset with a barestrconv.Atoiand never bounds it, so a minute>= 60(or a negative/signed one) is accepted and shifts the resolved local time by an arbitrary amount across everygetX(tz)accessor.Fix: reject a parsed minute outside
[0, 59]in the callee before the offset is computed. Valid offsets like-08:30and the existing+23:00hour case are unaffected.