Refactor Option to keep shared public API in a base class.#1196
Open
copybara-service[bot] wants to merge 1 commit into
Open
Refactor Option to keep shared public API in a base class.#1196copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
3c1fc44 to
6eb7d5e
Compare
Only a private subset of Option's functionality relies on the memory layout of a specific instantiation. We can reduce the logic and generated code by factoring the public API out into a shared base class. This also makes it easier to see what the Option api without having to read the documented code. PiperOrigin-RevId: 930609452
6eb7d5e to
5ea1ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Option to keep shared public API in a base class.
Only a private subset of Option's functionality relies on the memory layout of a specific instantiation. We can reduce the logic and generated code by factoring the public API out into a shared base class. This also makes it easier to see what the Option api without having to read the documented code.