Fix mem leak in composable bridging#1199
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
Previously, it was possible for composable bridging to cause a mem leak because of internal implementation details. In particular, it sometimes `std::move`d values in and out of intermediate type-erased buffers, and didn't call the destructor on the moved from slots. This was particularly a problem for types whose move constructors actually just perform a copy, which is valid C++ because destructors are supposed to be called on all values, including moved-from values. This change fixes this by adding a deferred call to the destructor so it always gets called on the type erased slot. PiperOrigin-RevId: 931161831
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mem leak in composable bridging
Previously, it was possible for composable bridging to cause a mem leak because of internal implementation details. In particular, it sometimes
std::moved values in and out of intermediate type-erased buffers, and didn't call the destructor on the moved from slots. This was particularly a problem for types whose move constructors actually just perform a copy, which is valid C++ because destructors are supposed to be called on all values, including moved-from values.This change fixes this by adding a deferred call to the destructor so it always gets called on the type erased slot.