Resolve ambiguity between std and rs::std namespaces in iterator_adapter.h#1210
Open
copybara-service[bot] wants to merge 1 commit into
Open
Resolve ambiguity between std and rs::std namespaces in iterator_adapter.h#1210copybara-service[bot] wants to merge 1 commit into
std and rs::std namespaces in iterator_adapter.h#1210copybara-service[bot] wants to merge 1 commit into
Conversation
…adapter.h
Most of our support C++ code can unambiguously refer to the top-level `std` namespace with just `std`. But Crubit binds Rust's `std` crate in the `rs::std` namespace, so inside the `rs` namespace, `std` resolves to that instead of the top-level `std`.
I checked for uses of `namespace rs {` and only found the one in this header, so I added a quick test that declares the `rs::std` namespace and includes the header, just to make sure that keeps compiling. I think that won't catch anything that can be SFINAE'd out, so we will want to cover this header with more tests in the future.
PiperOrigin-RevId: 931405770
fe95c98 to
8bf78f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve ambiguity between
stdandrs::stdnamespaces in iterator_adapter.hMost of our support C++ code can unambiguously refer to the top-level
stdnamespace with juststd. But Crubit binds Rust'sstdcrate in thers::stdnamespace, so inside thersnamespace,stdresolves to that instead of the top-levelstd.I checked for uses of
namespace rs {and only found the one in this header, so I added a quick test that declares thers::stdnamespace and includes the header, just to make sure that keeps compiling. I think that won't catch anything that can be SFINAE'd out, so we will want to cover this header with more tests in the future.