Remove __init__.py from bin/ and eval/; add Copybara import rewriting#6
Open
copybara-service[bot] wants to merge 1 commit into
Open
Remove __init__.py from bin/ and eval/; add Copybara import rewriting#6copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
1c5a24f to
8e84072
Compare
- Remove __init__.py from bin/ and eval/ so they are not treated as part of the core installable library. - Add reversible Copybara transformations to rewrite imports during export: `from dpsynth.bin import X` → `from bin import X` (and same for eval). Since bin/ and eval/ are at the repo root (not inside dpsynth/), the imports need rewriting. core.replace is reversible, so PR imports automatically get the inverse transformation. - Add pytest pythonpath config to pyproject.toml so namespace packages at the repo root are importable during test runs. - Change the test_local Copybara workflow mode from SQUASH to ITERATIVE so that individual commit descriptions are preserved when exporting to GitHub. PiperOrigin-RevId: 930589857
8e84072 to
5ba2f58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove init.py from bin/ and eval/; add Copybara import rewriting
the core installable library.
from dpsynth.bin import X→from bin import X(and same for eval).Since bin/ and eval/ are at the repo root (not inside dpsynth/), the imports
need rewriting. core.replace is reversible, so PR imports automatically get
the inverse transformation.
repo root are importable during test runs.
that individual commit descriptions are preserved when exporting to GitHub.