fix MultiMetric GraphDef not hashable under jit#5492
Open
mohsinm-dev wants to merge 1 commit into
Open
Conversation
Store _metric_names as tuple instead of list so the static GraphDef produced by nnx.split() is hashable when passed to jax.jit/nnx.jit.
vfdev-5
approved these changes
Jun 11, 2026
vfdev-5
left a comment
Collaborator
There was a problem hiding this comment.
I do no see any objections to make it this way and thus having MultiMetric graphdef hashable.
LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5489.
MultiMetric._metric_nameswas stored as alist. Since it's static graph metadata,GraphDef.__hash__fails when the graphdef is passed as a static jit argument. Changed totuple.