feat: type writer property as GLTFWriter in VariantMaterialExporterPlugin#5175
Open
rajkandula wants to merge 1 commit into
Open
feat: type writer property as GLTFWriter in VariantMaterialExporterPlugin#5175rajkandula wants to merge 1 commit into
rajkandula wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
anytype on thewriterproperty inVariantMaterialExporterPlugin.tswith the concreteGLTFWriterimported fromthree/examples/jsm/exporters/GLTFExporter.js.Since
@types/threeis missing declarations forprocessMaterialAsyncandjsononGLTFWriter, this PR utilizes TypeScript module augmentation to safely extend the type. It also adds a type predicate (material is Material) tocompatibleMaterialto safely narrow material types within loops and ternary expressions.This resolves the pending
@TODOcomment in the exporter plugin file.Reference Issue
None (resolves a pending inline TODO comment).
Testing
npm run build.npm run test:ciwith all tests passing:@google/model-viewer: 393 passed, 0 failed@google/model-viewer-effects: 13 passed, 0 failed@google/model-viewer-space-opera: 99 passed, 0 failed