[QwixOdmlSiblingBranch] Refactor metadata propagation and unify sibling-branch sharing.#294
Open
copybara-service[bot] wants to merge 1 commit into
Open
[QwixOdmlSiblingBranch] Refactor metadata propagation and unify sibling-branch sharing.#294copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…ng-branch sharing. Refactors the Qwix ODML metadata propagation system and sibling matching lifecycle to ensure robust quantization intent sharing and float path isolation across model eager execution and tracing/conversion pipelines. - Refactored `_maybe_fake_quant` to align tracer-sharing behavior between eager execution and graph tracing. By replacing over-inclusive immediate-quantization copying with strict, rule-matched sibling reuse, sibling branches correctly share the same quantized tracer, eliminating KeyErrors during model conversion. - Refactored `_forward_metadata` to properly support elementwise linear scaling and shifting operations (e.g., addition, multiplication, negation) by propagating structural quantization rules and fusion permissions downstream while stripping value-dependent metadata. PiperOrigin-RevId: 919902229
39fd8fd to
6e36c78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QwixOdmlSiblingBranch] Refactor metadata propagation and unify sibling-branch sharing.
Refactors the Qwix ODML metadata propagation system and sibling matching lifecycle to ensure robust quantization intent sharing and float path isolation across model eager execution and tracing/conversion pipelines.
_maybe_fake_quantto align tracer-sharing behavior between eager execution and graph tracing. By replacing over-inclusive immediate-quantization copying with strict, rule-matched sibling reuse, sibling branches correctly share the same quantized tracer, eliminating KeyErrors during model conversion._forward_metadatato properly support elementwise linear scaling and shifting operations (e.g., addition, multiplication, negation) by propagating structural quantization rules and fusion permissions downstream while stripping value-dependent metadata.