feat(sidekick/rust): track recording error info for discovery LROs#6304
Open
haphungw wants to merge 3 commits into
Open
feat(sidekick/rust): track recording error info for discovery LROs#6304haphungw wants to merge 3 commits into
haphungw wants to merge 3 commits into
Conversation
…ne status in lro traces
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies tracing logic in tracing.rs.mustache by replacing manual tracing blocks with the macros record_polling_attributes! and record_discovery_polling_result!. However, removing the #[cfg(google_cloud_unstable_tracing)] attribute from the first macro call may cause compilation errors when that configuration is disabled. It is recommended to restore this attribute.
68478fe to
9679b0b
Compare
westarle
approved these changes
Jun 10, 2026
haphungw
added a commit
to googleapis/google-cloud-rust
that referenced
this pull request
Jun 10, 2026
…o compatibility (#5843) Introduce telemetry injections for Discovery LROs. This ensures Discovery LROs can record rich error details upon completion, matching the behavior of standard LROs, and provides a cleaner interface for code generation. Used at googleapis/librarian#6304.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error telemetry for Discovery LROs so that their traces contain the same error information as standard LROs.
Staged @ googleapis/google-cloud-rust#5861
Fixes #6286