Report packages loading failure with a specific exit-code#4963
Open
podtserkovskiy wants to merge 1 commit into
Open
Report packages loading failure with a specific exit-code#4963podtserkovskiy wants to merge 1 commit into
podtserkovskiy wants to merge 1 commit into
Conversation
|
Hey, thank you for opening your first Pull Request ! |
|
|
Author
|
@ldez Is there something I can do to get this PR merged? |
Member
|
I'm unsure to understand how this "increases observability and will help to distinguish Can you provide more details? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
packages.Load()function can use an external package providerGOPACKAGESDRIVERfor third-party build-systems like Bazel or Buck2.Having a specific exit code when external driver fails would increase observability and will help to distinguish
GOPACKAGESDRIVER's failures from other kinds of failures.