Skip to content

chore(deps): bump fastmcp to >=3.2.0,<4 and move black to dev extra #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsonyy merged 4 commits into from
May 7, 2026
Merged

chore(deps): bump fastmcp to >=3.2.0,<4 and move black to dev extra #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d707ea9
chore(deps): bump fastmcp to >=3.2.0,<4 and move black to dev extra
dsonyy May 6, 2026
fecb4ed
fix(deps): pin black>=26.3.1 instead of moving to dev extra
dsonyy May 6, 2026
2b7c2e2
fix(deps): move black to [dev] extra so it ships out of production
dsonyy May 6, 2026
35286d2
fix(builder): pass stateless_http to mcp.run() instead of removed Fas…
dsonyy May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e ".[telemetry]"
pip install pytest pytest-asyncio pytest-cov
pip install -e ".[dev]"

- name: Run tests
run: |
Expand Down Expand Up @@ -57,8 +56,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e ".[telemetry]"
pip install ruff mypy
pip install -e ".[dev]"

- name: Run ruff format check
run: ruff format --check src/
Expand Down
15 changes: 11 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,10 @@ classifiers = [
dependencies = [
"typer>=0.15.4",
"rich>=14.0.0",
"fastmcp>=2.14.0,<2.15.0",
"fastmcp>=3.2.0,<4.0.0",
"pydantic>=2.11.0",
"pydantic-settings>=2.0.0",
"python-dotenv>=1.1.0",
"black>=24.10.0",
"pyjwt>=2.0.0",
"httpx>=0.28.1",
"posthog>=4.1.0",
Expand All @@ -47,6 +46,14 @@ dependencies = [
metrics = [
"prometheus-client>=0.22.1"
]
dev = [
"black>=26.3.1",
"pytest>=7.4.0",
"pytest-asyncio>=0.23.0",
"pytest-cov>=4.1.0",
"ruff>=0.1.0",
"mypy>=1.6.0"
]

[project.scripts]
golf = "golf.cli.main:app"
Expand Down Expand Up @@ -85,13 +92,12 @@ classifiers = [

[tool.poetry.dependencies]
python = ">=3.8" # Match requires-python
fastmcp = ">=2.14.0,<2.15.0"
fastmcp = ">=3.2.0,<4.0.0"
typer = {extras = ["all"], version = ">=0.15.4"}
pydantic = ">=2.11.0"
pydantic-settings = ">=2.0.0"
rich = ">=14.0.0"
python-dotenv = ">=1.1.0"
black = ">=24.10.0"
pyjwt = ">=2.0.0"
httpx = ">=0.28.1"
posthog = ">=4.1.0"
Expand All @@ -111,6 +117,7 @@ pytest-asyncio = "^0.23.0"
ruff = "^0.1.0"
mypy = "^1.6.0"
pytest-cov = "^4.1.0"
black = ">=26.3.1"

[tool.black]
line-length = 120
Expand Down
35 changes: 21 additions & 14 deletions src/golf/core/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from pathlib import Path
from typing import Any

import black
from rich.console import Console

from golf.auth import is_auth_configured
Expand Down Expand Up @@ -1279,10 +1278,6 @@ def _generate_server(self) -> None:
for key, value in auth_components["fastmcp_args"].items():
mcp_constructor_args.append(f"{key}={value}")

# Add stateless HTTP parameter if enabled
if self.settings.stateless_http:
mcp_constructor_args.append("stateless_http=True")

# Add OpenTelemetry parameters if enabled
if self.settings.opentelemetry_enabled:
mcp_constructor_args.append("lifespan=telemetry_lifespan")
Expand Down Expand Up @@ -1323,6 +1318,7 @@ def _generate_server(self) -> None:
f' transport_to_run = "{self.settings.transport}"',
"",
]
stateless_kwarg = ", stateless_http=True" if self.settings.stateless_http else ""

main_code.append("")

Expand Down Expand Up @@ -1434,8 +1430,8 @@ def _generate_server(self) -> None:
main_code.extend(
[
" # Run HTTP server with middleware using FastMCP's run method",
' mcp.run(transport="streamable-http", host=host, '
'port=port, log_level="info", middleware=middleware, show_banner=False)',
f' mcp.run(transport="streamable-http", host=host, '
f'port=port, log_level="info", middleware=middleware, show_banner=False{stateless_kwarg})',
]
)
else:
Expand All @@ -1444,16 +1440,16 @@ def _generate_server(self) -> None:
" # Run HTTP server with middleware using FastMCP's run method",
f' mcp.run(transport="streamable-http", host=host, '
f'port=port, path="{endpoint_path}", log_level="info", '
f"middleware=middleware, show_banner=False)",
f"middleware=middleware, show_banner=False{stateless_kwarg})",
]
)
else:
if self._is_fastmcp_version_gte("2.12.0"):
main_code.extend(
[
" # Run HTTP server using FastMCP's run method",
' mcp.run(transport="streamable-http", host=host, '
'port=port, log_level="info", show_banner=False)',
f' mcp.run(transport="streamable-http", host=host, '
f'port=port, log_level="info", show_banner=False{stateless_kwarg})',
]
)
else:
Expand All @@ -1462,7 +1458,7 @@ def _generate_server(self) -> None:
" # Run HTTP server using FastMCP's run method",
f' mcp.run(transport="streamable-http", host=host, '
f'port=port, path="{endpoint_path}", log_level="info", '
f"show_banner=False)",
f"show_banner=False{stateless_kwarg})",
]
)
else:
Expand Down Expand Up @@ -1504,9 +1500,16 @@ def _generate_server(self) -> None:
+ main_code
)

# Format with black
# Format with black (build-time dep; install with `pip install golf-mcp[dev]`)
try:
import black

code = black.format_str(code, mode=black.Mode())
except ImportError:
console.print(
"[yellow]Warning: black is not installed; generated server.py will not be formatted. "
"Install with `pip install golf-mcp[dev]`.[/yellow]"
)
except Exception as e:
console.print(f"[yellow]Warning: Could not format server.py: {e}[/yellow]")

Expand Down Expand Up @@ -1908,14 +1911,18 @@ def build_project(
server_code_content[:app_pos] + auth_routes_code + "\n\n" + server_code_content[app_pos:]
)

# Format with black before writing
# Format with black before writing (build-time dep)
final_code_to_write = modified_code
try:
import black

final_code_to_write = black.format_str(modified_code, mode=black.Mode())
except ImportError:
pass # already warned above when generating server.py
except Exception as e:
console.print(
f"[yellow]Warning: Could not format server.py after auth routes injection: {e}[/yellow]"
)
final_code_to_write = modified_code

with open(server_file, "w") as f:
f.write(final_code_to_write)
Expand Down
Loading