Bump dependencies#1064
Open
kgaughan wants to merge 5 commits into
Open
Conversation
As the Go toolchain is being bumped too, some additional changes were needed in the testdata and also to the code to deal with issues flagged during the build. golangci-lint also needs a bump to the most recent v1.* to avoid the following breakage: ``` $ make INFO: Starting build fmt ./ci/go-fmt.sh .../bin/gofmt valid gofmt INFO: Starting build lint go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59 ../../go/pkg/mod/golang.org/x/tools@v0.22.0/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64) make: *** [Makefile:40: lint] Error 1 ``` A bump to v2 can come later.
Open
Contributor
Author
|
I guess I should note why I bumped the toolchain to 1.25.11: when I got the Trivy scans working, it detected a vulnerability in the Go standard library. |
3 tasks
aelsabbahy
reviewed
Jun 14, 2026
aelsabbahy
left a comment
Member
There was a problem hiding this comment.
Looks good, small question/feedback since it impacts the user experience.
| Matching: negated_basic_reader: matches: | ||
| Error | ||
| ContainElements matcher expects an array/slice/map. Got: | ||
| ContainElements matcher expects an array/slice/map/iter.Seq/iter.Seq2. Got: |
Member
There was a problem hiding this comment.
Hmm.. this output seems confusing. What's causing that change?
We may have to wrap this error.
Contributor
Author
There was a problem hiding this comment.
That's caused by the update of the Go runtime to 1.23+. iter was introduced in Go 1.23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
As the Go toolchain is being bumped too, some additional changes were needed in the testdata and also to the code to deal with issues flagged during the build. golangci-lint also needs a bump to the most recent v1.* to avoid the following breakage:
A bump to v2 can come later.golangci-lint v1.64.8 and go v1.25 aren't playing nice together, forcing a bump to v2.12.2. I've included the required changes to make the linter happy too.Finally, I've bumped the actions for Trivy in
trivy-schedule.yamlto fix that pipeline too. Closes #1051.