Skip to content

Simplifies /src/row.rs : 'update()' method implementation#616

Open
VRAM-RAM wants to merge 2 commits into
ilai-deutel:masterfrom
VRAM-RAM:simplify-update_function
Open

Simplifies /src/row.rs : 'update()' method implementation#616
VRAM-RAM wants to merge 2 commits into
ilai-deutel:masterfrom
VRAM-RAM:simplify-update_function

Conversation

@VRAM-RAM

@VRAM-RAM VRAM-RAM commented Jun 2, 2026

Copy link
Copy Markdown

Simplify the update() method

Improves readability and removes an unnecessary allocation in the update() method.

Changes:

  • Replaced tuple-based side-effect expressions (let (..) = (...)) with direct method calls (self.render.clear(), etc.).
  • Removed c.into() and used push() for non-tab characters, avoiding the creation of a temporary String.
  • Replaced (rx, cx) = (...) with rx += ...; cx += ...;, which is more idiomatic and easier to read.

No functional changes intended.

@VRAM-RAM VRAM-RAM requested a review from ilai-deutel as a code owner June 2, 2026 18:30
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 26839991772

Coverage remained the same at 69.538%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 5 of 5 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1277
Covered Lines: 888
Line Coverage: 69.54%
Coverage Strength: 1071.88 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants