Skip to content

Restore the colours to the previous one instead of the theme default#1602

Open
ailin-nemui wants to merge 8 commits into
irssi:masterfrom
ailin-nemui:colorstack
Open

Restore the colours to the previous one instead of the theme default#1602
ailin-nemui wants to merge 8 commits into
irssi:masterfrom
ailin-nemui:colorstack

Conversation

@ailin-nemui

Copy link
Copy Markdown
Contributor

Adds a history of maximum 10 colours which irssi can revert back to.

Fixes #1592

@ailin-nemui ailin-nemui force-pushed the colorstack branch 2 times, most recently from 44e757e to b1a6735 Compare January 3, 2026 16:53
@ailin-nemui ailin-nemui force-pushed the colorstack branch 2 times, most recently from 18ad470 to ae9f6d7 Compare January 3, 2026 18:54
@ailin-nemui

Copy link
Copy Markdown
Contributor Author

@soulseller you're welcome to test it

@Zannick I added ^O to strip_real_length like you suggested in #95

@incognico see if this fixes issue #31

@horgh horgh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Comment thread src/core/special-vars.c
#include <irssi/src/core/signals.h>
#include <irssi/src/core/special-vars.h>
#include <irssi/src/core/utf8.h>
#include <irssi/src/fe-common/core/formats.h>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be depending on fe-common in core? Maybe we could move the constants if this is the right spot to be using them.

fg = -1;
bg = -1;
fg = 99;
bg = 99;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 99 correspond to? I wonder if naming it would help. I see it's also in lines 1678 and 1682 below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text style reset overrides theme colors

2 participants