refactor: convert ClientGatewayService to interface with async factory pattern#1116
Open
trim21 wants to merge 2 commits into
Open
refactor: convert ClientGatewayService to interface with async factory pattern#1116trim21 wants to merge 2 commits into
trim21 wants to merge 2 commits into
Conversation
…y pattern Replace the abstract class with a ClientGatewayService interface plus BaseClientGatewayService abstract class that holds shared retry/error logic. Each implementation now: - Takes dependencies (ClientRequestManager, AvailableMethodCalls) as constructor arguments, eliminating async field initializers - Provides a static async create(user) factory for construction - Has testGateway() reserved solely for connectivity re-validation during retries, no longer used for async init rTorrent's fetchAvailableMethodCalls is extracted to a standalone function taking ClientRequestManager as an argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientGatewayServiceabstract class with an interface and a sharedBaseClientGatewayServiceabstract classClientRequestManager,AvailableMethodCalls) via constructor arguments, eliminating async field initializersstatic async create(user)factory for constructionfetchAvailableMethodCallsis extracted to a standalone function takingClientRequestManageras an argument — no moreavailableMethodCalls = this.fetchAvailableMethodCalls()patterntestGateway()is now reserved solely for connectivity re-validation during retries, no longer serving as an async factory/initializer