feat: High-Fidelity sensory UX & On-Chain Sync for The Farm (The "Trust" Upgrade) v2#71
feat: High-Fidelity sensory UX & On-Chain Sync for The Farm (The "Trust" Upgrade) v2#71tacticalnoot wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7661e896a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const accountResponse = await server.getAccount(farmerAddress).catch(() => null); | ||
| if (!accountResponse) { | ||
| return { verified: false }; |
There was a problem hiding this comment.
Use a valid source account for attestation simulation
checkAttestation builds its read-only simulation by calling server.getAccount(farmerAddress) and returns { verified: false } when that lookup fails. In this flow, callers pass userState.contractId (a smart-wallet contract ID), so this lookup can fail before simulation runs, causing existing attestations to be silently missed and the new on-chain sync feature to report users as unverified.
Useful? React with 👍 / 👎.
| const tierName = tierOrder[status.tier]; | ||
| setAttestationResult("circom", tierName, { | ||
| ok: true, | ||
| txHash: status.commitment || "0x_on_chain", |
There was a problem hiding this comment.
Keep commitment separate from transaction hash in synced state
When syncOnChainStatus hydrates an existing attestation, it stores status.commitment in the txHash field, but that value is not a transaction hash. The verified card then builds a Stellar Expert transaction URL from this field, so already-verified users get a broken explorer link instead of a valid on-chain transaction reference.
Useful? React with 👍 / 👎.
This PR implements a comprehensive high-fidelity UX overhaul for "The Farm" to bridge the "trust gap" and ensure on-chain ZK verification feels mathematically final and permanent.
This is a re-submission with a clean history based on
upstream/noot.🟢 High-Fidelity UX & Trust Upgrades
TypeErrorregardingPasskeyKitinitialization and standardized all transactions to use thesignAndSendhelper with gasless relayer support.Closes # [ZK Flow Error]
Co-authored-by: Antigravity antigravity@google.com