Add padding to guides categories and fix layout on phones#716
Merged
Conversation
shawkins
approved these changes
Mar 16, 2026
shawkins
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with this change. I may have misunderstood the original complaint about how things looked - I thought the concern was more about having the categories on multiple lines.
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Member
Author
|
@shawkins Yes, the concern was about the single line - I thought that we could live with it and just make things nicer... But, I moved a little bit further and make more changes to be also ~compliant with Bootstrap and secondary navbars. Please take a look. |
shawkins
approved these changes
Mar 19, 2026
shawkins
left a comment
Contributor
There was a problem hiding this comment.
Still looks good. I do prefer having the drop down for categories - especially on mobile.
ahus1
approved these changes
Mar 19, 2026
Member
Author
Yes, on the mobile, it'd really help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OLD
Screencast.From.2026-03-16.10-38-50.mp4
NEW
Screencast.From.2026-03-18.10-30-47.mp4
@shawkins @vmuzikar I believe this might be a minimal fix for the layout on phones and the gap... Later, we can discuss this follow-up:
WDYT?