[pull] master from gbdev:master#52
Open
pull[bot] wants to merge 848 commits into
Open
Conversation
This reverts commit 223b3d1.
gcc 15.2.1 20250813 complains "address of automatic variable can escape to `musttail` call" from `-Wmaybe-musttail-local-addr`, and guaranteeing tail-call optimization cross-platform is more trouble than it's worth.
since they may call `isatty` which can change `errno` Fixes #1857
This was the only RPN case to not assign a deliberate value in all possible branches. Fixes #1858
Dot-only names could also trip an assertion in `make develop` when used as labels
…1867) - ID numbers (for fstack nodes, sections, symbols, patches, etc) might be too large for their associated collection - Enum values might be invalid - Bank values might be out of range for their section types
…entinel The `errorNoTrace` case for the empty-string sentinel was unreachable, so we can just have a `fatalNoTrace` error right away.
…elop` The Bison-generated parser skeleton otherwise triggers this warning with Apple clang++ for `yynerrs_`.
…or `RPNCommand`s
…Content` (#1981) Instead of reading 64 characters at a time into a rolling buffer as `shiftChar()` is called, we read 8192 characters at a time into a complete buffer before any `peek()`/`shiftChar()` operations.
Some test cases need CRLF line endings checked out even on Unix. Also some source files had inadvertently contained CR bytes.
A fresh clone showed a diff even without any bytes changed.
This avoids constructing temporary `std::string` objects on lookup
- Fix logic for color set comparison (which affects sorting them) - Prune color sets which are proper subsets of newly-encountered ones (a comment implied we were already doing this, but we weren't) - Add more verbose logging to debug this behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )