Merge all plain-object anyOf branches instead of keeping only the first#703
Open
pushpak1300 wants to merge 3 commits into
Open
Merge all plain-object anyOf branches instead of keeping only the first#703pushpak1300 wants to merge 3 commits into
pushpak1300 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normalizer currently collapses
anyOf/oneOfto the first branch, so discriminated union schemas lose all variant-specific properties:All plain-object branches are unioned into one schema. For a shared discriminator property with
enumvalues in each branch, the enums are merged. Therequiredintersection keeps only fields required in every opinionated branch.Three correctness fixes are also included:
requiredwas incorrectly promoted when only one of multiple branches declared it; thearray_mergefallback now usesmergeSchemato avoid shallow-overwriting already-merged properties when bothanyOfandoneOfappear on the same node; andis_arrayguards prevent aTypeErrorfrom non-arrayenumvalues in malformed MCP tool schemas.