Allow disabling the embeddings cache per request#706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's no way to turn off embeddings caching for a single request once it's enabled globally via
ai.caching.embeddings.cache. Passingcache: falseis silently ignored, and->cache(0)/->cache(-1)still return an existing cached entry.Now an explicit disable wins over the global config:
Under the hood the request now tracks an explicit cache intent (default to config, or force on/off) instead of inferring it from whether a TTL was set, so a zero/negative TTL means "don't cache" rather than "cache with a 0s TTL". Tests added.
Fixes #691