Skip to content

Add Visium HD, Imaging-based, and Dimension Reduction on text annotation in vignette#20

Merged
lmweber merged 6 commits into
lmweber:develfrom
estellad:estellad
Oct 6, 2025
Merged

Add Visium HD, Imaging-based, and Dimension Reduction on text annotation in vignette#20
lmweber merged 6 commits into
lmweber:develfrom
estellad:estellad

Conversation

@estellad

@estellad estellad commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Update vignette with new functionalities implemented for HD, and imaging-based.

@lmweber

lmweber commented Oct 6, 2025

Copy link
Copy Markdown
Owner

This looks good, thanks.

One question - why is arrow needed in Imports: in DESCRIPTION? It's ok if it is needed, but I wanted to check that I understand.

And thanks also for designing the sticker for this package - this one also looks really nice.

@estellad

estellad commented Oct 6, 2025

Copy link
Copy Markdown
Contributor Author

Hi Lukas,

arrow is needed by VisiumIO, and since we demonstrate Visium HD in the vignette, we will need VisiumIO to read it from OSTA.data.

@lmweber

lmweber commented Oct 6, 2025

Copy link
Copy Markdown
Owner

Ok thanks, that sounds good. In this case I'll move arrow to Suggests: instead of Imports:. We can use Suggests: for any packages that are only used in the vignette or examples.

The updates look great - thank you for this PR. I'll update DESCRIPTION and add a few additional minor formatting edits, and then will merge.

@lmweber lmweber merged commit d2d8e66 into lmweber:devel Oct 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants