Turn pulumi/esc into a re-export shim for the monorepo engine#663
Draft
borisschlosser wants to merge 1 commit into
Draft
Turn pulumi/esc into a re-export shim for the monorepo engine#663borisschlosser wants to merge 1 commit into
borisschlosser wants to merge 1 commit into
Conversation
6b3cb34 to
c99deec
Compare
The ESC engine now lives in github.com/pulumi/pulumi at sdk/v3/go/esc. This repo becomes a thin re-export shim so existing imports of github.com/pulumi/esc/... keep working unchanged for all consumers. - Every engine package (esc, ast, eval, syntax, syntax/encoding, schema, diags, analysis) is generated re-export aliases (type X = canonical.X) plus hand-written wrappers for generic functions. Type aliases preserve type identity. - Removed the engine implementation, internal/, and cmd/ (the CLI, REST client and standalone binary moved to github.com/pulumi/pulumi). `pulumi esc` is the entry point. - go.mod depends on the pulumi SDK; no local replace directives. The pulumi dependency is pinned to a development commit until the consolidation is released. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
c99deec to
3a97a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESC engine now lives in
github.com/pulumi/pulumiatsdk/v3/go/esc. This repo becomes a thin re-export shim so every existing import ofgithub.com/pulumi/esc/...keeps working unchanged — no consumer needs to migrate.esc,ast,eval,syntax,syntax/encoding,schema,diags,analysis) is generated re-export aliases (type X = canonical.X) + hand-written wrappers for the few generic functions. Type aliases preserve type identity, so values cross the boundary transparently.internal/, andcmd/(the CLI, REST client and standalone binary moved to the monorepo).pulumi escis the entry point.go.moddepends on the pulumi SDK at a development pseudo-version; no local replace directives, so CI resolves it. Pin to the release version once the consolidation ships.Verified:
go build ./...andgo vet ./...clean.🤖 Generated with Claude Code