Skip to content

Feature/1111 Drop-down to add skills in project technology#1174

Open
schiltpuzzle wants to merge 19 commits into
masterfrom
feature/1111-drop-down-to-add-skills-in-project-technology
Open

Feature/1111 Drop-down to add skills in project technology#1174
schiltpuzzle wants to merge 19 commits into
masterfrom
feature/1111-drop-down-to-add-skills-in-project-technology

Conversation

@schiltpuzzle

Copy link
Copy Markdown
Collaborator

No description provided.

@schiltpuzzle schiltpuzzle linked an issue May 20, 2026 that may be closed by this pull request
4 tasks
@schiltpuzzle schiltpuzzle changed the title feat: add attribute to project #1111 Feature/1111 Drop-down to add skills in project technology May 20, 2026
@schiltpuzzle schiltpuzzle force-pushed the feature/1111-drop-down-to-add-skills-in-project-technology branch from c90aa88 to 4341d12 Compare June 3, 2026 14:06
@schiltpuzzle

schiltpuzzle commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

PR Status — 03.06.2026

Reminder: Understand the goal first, then work on it.

Done

  • Finished Feature
  • Fixed couple of tests

ToDos

  • Fix remaining 3 Tests
  • Peer Review

@lcanobbio lcanobbio self-assigned this Jun 5, 2026
@lcanobbio lcanobbio requested a review from Miguel7373 June 5, 2026 10:55
@Miguel7373 Miguel7373 self-assigned this Jun 5, 2026
@lcanobbio lcanobbio removed their assignment Jun 5, 2026

@Miguel7373 Miguel7373 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks pretty good. There is just no test yet that selects multiple technologies in the Slim select. You should write one of those.

Comment thread app/views/projects/_project.html.haml Outdated
@Miguel7373 Miguel7373 removed their assignment Jun 8, 2026
@Miguel7373

Copy link
Copy Markdown
Collaborator

Also rebase 😃

@schiltpuzzle schiltpuzzle force-pushed the feature/1111-drop-down-to-add-skills-in-project-technology branch from 176a5b2 to b495b18 Compare June 10, 2026 08:29
@schiltpuzzle

schiltpuzzle commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

PR Status — 10.06.2026

Reminder: Understand the goal first, then work on it.

Done

  • I finished adding selects that add multiple technologies in the Slim select

ToDos

  • At the moment the pipeline is failing, because of the bundle-audit finding and old version of a gem. I didn't see a dependabot pr for this gem...

@lcanobbio lcanobbio force-pushed the feature/1111-drop-down-to-add-skills-in-project-technology branch from 1f51efe to 8046f5f Compare June 12, 2026 13:03
@lcanobbio lcanobbio self-assigned this Jun 15, 2026
@lcanobbio lcanobbio force-pushed the feature/1111-drop-down-to-add-skills-in-project-technology branch from 267b674 to df3a289 Compare June 15, 2026 06:17

@Miguel7373 Miguel7373 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something does not work here. It seems to only save one in the multi-drop-down and nothing more than that. Look into why that happens and fix it.

Comment thread db/migrate/20260612131400_create_join_table_project_skill.rb Outdated
Comment thread db/schema.rb Outdated
@lcanobbio

Copy link
Copy Markdown
Collaborator

I have fixt the dropdown. it should now display all the skills that have already been selected

@Miguel7373 Miguel7373 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@Miguel7373 Miguel7373 marked this pull request as ready for review June 15, 2026 11:39
@Miguel7373 Miguel7373 requested a review from Robin481 as a code owner June 15, 2026 11:39

@Robin481 Robin481 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First a few pieces of functionality feedback before I look at the code in too much detail:

  • Why are the skills in the dropdown not sorted alphabetically? Make them sorted
  • When navigating via the up and down arrow the already selected skills are not highlighted when navigating over them. This is especially bad if you select the first 5 skills and then want to navigate to the sixth one. I would argue we should just remove skills from the dropdown that are already selected. Being able to remove the via backspace or clicking on the little cross is good enough.
  • After searching for a skill and then pressing enter the search input should be cleared.
  • The dropdown has some horribly confusing boundary behaviour. E.g. Open the dropdown via arrow keys, select the third last skill and then the second last skill, press down and enter to deselect and then sometimes the down key goes up and silly stuff like that.
  • When selecting a skill via enter you can then still continue searching for other skills. When you select one with the mouse button the search field loses focus and you have to manually press into it again.
  • Don't force the user to remove the free text field via validation. We should still allow the user to make changes to projects without being forced to migrate to the new skills.

@Robin481 Robin481 removed their assignment Jun 15, 2026
@lcanobbio lcanobbio force-pushed the feature/1111-drop-down-to-add-skills-in-project-technology branch from ceac168 to 5f90d95 Compare June 16, 2026 14:20
@lcanobbio

Copy link
Copy Markdown
Collaborator

PR Status — 16.06.2026

Reminder: Understand the goal first, then work on it.

Done

  • I have resolved all the bugs in @Robin481 comment

ToDos

  • Send this PR into review maybe Peer review at first about the new changes
  • If the review has been returned, resolve the conversion

@lcanobbio lcanobbio removed their assignment Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop-down to add skills in project technology

4 participants