Feature/1111 Drop-down to add skills in project technology#1174
Open
schiltpuzzle wants to merge 19 commits into
Open
Feature/1111 Drop-down to add skills in project technology#1174schiltpuzzle wants to merge 19 commits into
schiltpuzzle wants to merge 19 commits into
Conversation
4 tasks
c90aa88 to
4341d12
Compare
Collaborator
Author
PR Status — 03.06.2026Reminder: Understand the goal first, then work on it.Done
ToDos
|
Miguel7373
requested changes
Jun 8, 2026
Miguel7373
left a comment
Collaborator
There was a problem hiding this comment.
This PR looks pretty good. There is just no test yet that selects multiple technologies in the Slim select. You should write one of those.
Collaborator
|
Also rebase 😃 |
176a5b2 to
b495b18
Compare
Collaborator
Author
PR Status — 10.06.2026Reminder: Understand the goal first, then work on it.Done
ToDos
|
1f51efe to
8046f5f
Compare
267b674 to
df3a289
Compare
Miguel7373
requested changes
Jun 15, 2026
Miguel7373
left a comment
Collaborator
There was a problem hiding this comment.
Something does not work here. It seems to only save one in the multi-drop-down and nothing more than that. Look into why that happens and fix it.
Collaborator
|
I have fixt the dropdown. it should now display all the skills that have already been selected |
Robin481
requested changes
Jun 15, 2026
Member
There was a problem hiding this comment.
First a few pieces of functionality feedback before I look at the code in too much detail:
- Why are the skills in the dropdown not sorted alphabetically? Make them sorted
- When navigating via the up and down arrow the already selected skills are not highlighted when navigating over them. This is especially bad if you select the first 5 skills and then want to navigate to the sixth one. I would argue we should just remove skills from the dropdown that are already selected. Being able to remove the via backspace or clicking on the little cross is good enough.
- After searching for a skill and then pressing enter the search input should be cleared.
- The dropdown has some horribly confusing boundary behaviour. E.g. Open the dropdown via arrow keys, select the third last skill and then the second last skill, press down and enter to deselect and then sometimes the down key goes up and silly stuff like that.
- When selecting a skill via enter you can then still continue searching for other skills. When you select one with the mouse button the search field loses focus and you have to manually press into it again.
- Don't force the user to remove the free text field via validation. We should still allow the user to make changes to projects without being forced to migrate to the new skills.
ceac168 to
5f90d95
Compare
Collaborator
PR Status — 16.06.2026Reminder: Understand the goal first, then work on it.Done
ToDos
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.