Fix #4665: list_cameras() returns None on Windows with integrated camera#4800
Open
samsepro wants to merge 2 commits into
Open
Fix #4665: list_cameras() returns None on Windows with integrated camera#4800samsepro wants to merge 2 commits into
samsepro wants to merge 2 commits into
Conversation
…ed camera Add Windows Media Foundation (MSMF) backend to _camera.c: - list_cameras() now enumerates cameras via MFEnumDeviceSources - Implement camera_start/stop/get_image/get_raw for Windows - Handle format change events on first ReadSample (retry loop) - Force RGB32 output format for consistent frame capture - Add win_source, win_reader, device_index fields to pgCameraObject - Add CAM_MSMF constant to camera.h - Accept both int index and str device name in Camera() - Add MF libs to Setup_Win_Camera.in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem :
pygame.camera.list_cameras()returnsNoneon Windows with integratedwebcams because the
#elsebranch in the original code didPy_RETURN_NONE.Solution :
Add a Windows Media Foundation (MSMF) backend to
_camera.cthat:MFEnumDeviceSourcesIMFActivateandIMFSourceReaderReadSamplewith a retry loopintindex andstrdevice name inCamera()Testing :
Tested on Windows 11 with integrated webcam (Integrated Webcam).
All 34 unit tests pass.
Fixes #4665