ENH: Time based kernel gwlearn#874
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
=====================================
Coverage 85.5% 85.6%
=====================================
Files 151 152 +1
Lines 16119 16172 +53
=====================================
+ Hits 13785 13836 +51
- Misses 2334 2336 +2
🚀 New features to boost your workflow:
|
lemme fix these first.. rest all tests are passing. |
aa7c65e to
3a928eb
Compare
3a928eb to
dcf7e13
Compare
|
will switch to a method of Graph.build_spatiotemporal() in next commit, since as suggested, the scale_by_kernel method seemed unintuitive. |
|
Newer implementation: Low-level: st_graph = temporal_g.multiply(spatial_g)High-level: st_graph = Graph.build_spatiotemporal(gdf, t=t, spatial_bandwidth=500, temporal_bandwidth=365)This build a spatiotemporal graph with: |
|
Stuff like this requires API discussion and agreement in an issue before PR. While there is an issue, there's no discussion nor agreement in there. |
|
Ah, I'm sorry, I misinterpreted it as being ready for a PR. Let's move this discussion over to that issue if you please? |
Hello! Please make sure to check all these boxes before submitting a Pull Request
(PR). Once you have checked the boxes, feel free to remove all text except the
justification in point 5.
pyteston your changes. Continuous integration will be run on all PRs with GitHub Actions, but it is good practice to test changes locally prior to a making a PR.pysal/masterbranch.docstrings and
unittests?
reviewer and added relevant labels
This PR allows building a Spatiotemporal Graph for ultimately helps in building a GWLearn api for better spatiotemporal model support.