Preserve errno on Windows serial open failures#866
Open
RobBotic1 wants to merge 1 commit into
Open
Conversation
Serial.open() on Windows raised SerialException from a single formatted string, stringifying the WinError and discarding its structured error code. As a result, SerialException.errno was always None on Windows, while the POSIX path populates it via the OSError constructor. Callers could not branch on the failure cause (port not found vs. access denied vs. busy) without parsing the exception message. Pass the error code as the first positional argument so the OSError base class sets .errno, mirroring serialposix.py. The message format is unchanged, so this is non-breaking for code that only reads str(e). Fixes pyserial#865
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serial.open() on Windows raised SerialException from a single formatted string, stringifying the WinError and discarding its structured error code. As a result, SerialException.errno was always None on Windows, while the POSIX path populates it via the OSError constructor. Callers could not branch on the failure cause (port not found vs. access denied vs. busy) without parsing the exception message.
Pass the error code as the first positional argument so the OSError base class sets .errno, mirroring serialposix.py. The message format is unchanged, so this is non-breaking for code that only reads str(e).
Fixes #865