Fix build warnings: unused variables, lifetime elision, and dead code in macros#2
Draft
Copilot wants to merge 3 commits into
Draft
Fix build warnings: unused variables, lifetime elision, and dead code in macros#2Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…ions Co-authored-by: pgdb99-wq <254882216+pgdb99-wq@users.noreply.github.com>
…ead code lints Co-authored-by: pgdb99-wq <254882216+pgdb99-wq@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unused field and function warnings
Fix build warnings: unused variables, lifetime elision, and dead code in macros
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves compiler warnings from unused FFI parameters, ambiguous lifetime elision in OpenXR layer builders, and dead code warnings from macro-generated structs.
Changes
FFI parameter warnings (
alvr/client_core/src/c_api.rs)messageparameters with_inalvr_dbg_client_implandalvr_dbg_decoderLifetime elision warnings (
alvr/client_openxr/)'_lifetime annotations toProjectionLayerBuilderandCompositionLayerProjectionreturn types ingraphics.rs,lobby.rs, andstream.rsMacro-generated dead code (
alvr/session/)[lints.rust]configuration toCargo.tomlto suppressdead_codewarnings forSettingsSchemaderive macros that generate unused helper codeExample of lifetime fix:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/zarik5/cargo-apk/commits/HEAD/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo install --git REDACTED cargo-apk embed-bitcode=no --allow=clippy::used_underscore_binding .5.54/src/lib.rs --warn=clippy::unnecessary_semicolon --allow=clippy::unnecessary_cast --allow=clippy::uninlined_format_args --warn=clippy::ptr_as_ptr bf.c�� bf.clap_derive.2/tmp/cargo-installgD26kV/release/deps/libos_str_bytes-052189cdd8bd5545.rlib bf.clap_derive.2/tmp/cargo-installgD26kV/release/deps/libiref-d37629fa03ba5d57.rlib bin/rustc bf.clap_derive.2/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc rcgu.o bf.clap_derive.2build_script_build bin/rustc(http block)sdk.picovr.com/usr/bin/curl curl -L -o /tmp/xshell-tmp-dir-1/temp_download.zip --url REDACTED d-6d7ecb28e8f9887a.build_script_build.9a1b81b8fe09d3c3-cgu.0.rcgu.o d-6d7ecb28e8f9887a.build_script_build.9a1b81b8fe09d3c3-cgu.1.rcgu.o d-6d7ecb28e8f9887a.bl36ofum0ivelnbzmmivnrola.rcgu.o feature="derive" --cfg 64-REDACTED-linux-gnu/lib/libstd-225863f279df55c4.rlib 64-REDACTED-linux-gnu/lib/libpanic_unwind-932f22f820d1e5ec.rlib 64-REDACTED-linux-gnu/lib/libobject-2dc10b344e05b569.rlib 64-REDACTED-linux-gnu/lib/libmemchr-09f2ab7e0d97e07a.rlib 64-REDACTED-linux-gnu/lib/libaddr2line-11d54e777384a9e5.rlib 64-REDACTED-linux-gnu/lib/libgimli-35018e994bad7042.rlib 64-REDACTED-linux-gnu/lib/libcfg_if-6a40188dd7d989d2.rlib 64-REDACTED-linux-gnu/lib/librustc_demangle-43b2ff22c18e1125.rlib 64-REDACTED-linux-gnu/lib/libstd_detect-5978f0713dd5442d.rlib(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.