Allow loading pryrc in other location even if XDG env is set#2184
Open
ttych wants to merge 1 commit into
Open
Conversation
3c36797 to
9560d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR is to allow loading pryrc in ~/.pryrc even if XDG_CONFIG_HOME is set.
On Linux environment, when loading graphically, XDG environment is set.
On the same Linux environment when loading through ssh, XDG environment is not set.
So since pry is not a graphical tool, make it dependent to X environment may be a bit restrictive ?
This change a little bit the behavior for default rc,
so when XDG environment is set (for X environment),
but the X "standard" path are not used for pry which is not a graphical tool (for the moment ?),
it allows a fallback to ~/.pryrc.