Skip to content

Added run test command above run#1960

Open
oakenknight wants to merge 3 commits into
quint-co:mainfrom
oakenknight:aleksandar/run-above-run
Open

Added run test command above run#1960
oakenknight wants to merge 3 commits into
quint-co:mainfrom
oakenknight:aleksandar/run-above-run

Conversation

@oakenknight

@oakenknight oakenknight commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Hey,
This is a PR that introduces Run test button above a run. Below are screenshots how the feature looks:

Button added above run
Pop-up for max-samples configuration

  • I have read and I understand the Note on AI-assisted contributions
  • Changes manually tested locally and confirmed to work as described
    (including screenshots is helpful)
  • Tests added for any new code
  • Documentation added for any new functionality
  • Entries added to the respective CHANGELOG.md for any new functionality

@oakenknight oakenknight requested a review from bugarela March 30, 2026 16:18
@oakenknight oakenknight changed the title Added run test command above run Added run test command above run Mar 30, 2026
@beu5a beu5a self-requested a review March 31, 2026 06:58
@beu5a

beu5a commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

Hey,
Thanks for working on this 🫶
I wanted to look at the PR asap in case we can merge this before the next release. After taking a quick pass, I have 2 main concerns:

  • If I understood correctly, there is no way to configure --max-samples . The PR hardcodes: testTerminal.sendText(quint test ${filePath} --match ^${testName}$). you'd have to manually re-run the command in the terminal to adjust it.
  • Module instantiation with constants is not handled. If your module M has constants (e.g. const N: int) and a run test, running quint test M.qnt will fail because M has uninstantiated constants. The typical way to make tests runnable is to create a concrete instantiation: module M_concrete = M(N = 5). The quint test CLI handles this via --main M_concrete, but the PR doesn't just passes the file.

@oakenknight

Copy link
Copy Markdown
Contributor Author
  • If I understood correctly, there is no way to configure --max-samples . The PR hardcodes: testTerminal.sendText(quint test ${filePath} --match ^${testName}$). you'd have to manually re-run the command in the terminal to adjust it.

I've handled this with a top level pop-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants