Skip to content

ci(workflow): add spotless ktlint checks#686

Draft
xmready wants to merge 1 commit into
quik-sms:masterfrom
xmready:feature/ktlint-spotless
Draft

ci(workflow): add spotless ktlint checks#686
xmready wants to merge 1 commit into
quik-sms:masterfrom
xmready:feature/ktlint-spotless

Conversation

@xmready

@xmready xmready commented Jan 17, 2026

Copy link
Copy Markdown

.editorconfig

  • 4-space indentation
  • IntelliJ IDEA code style
  • Enabled standard and experimental ktlint rules
  • Disabled rules for Android compatibility (comment spacing, package naming, backing property naming)

build.gradle files

  • Sorted Gradle extra properties
  • Added Spotless Plugin
  • Applied Plugin to Modules excluding android-smsmms
  • Configured Ktlint

build-on-pull.yml workflow

  • spotlessCheck (fastest) catches formatting issues
  • Android-specific linting (slower but still quick), validates code quality before build
  • Build only proceeds if quality checks pass
  • Stops pipeline early on any quality violations
  • Quality checks together, then build, then validation
  • Keeps expensive operations (build, tests) after lightweight checks
  • Android lint may be slower than spotless; if this causes issues, we could lint after build

Consider for build-and-release.yml

?????????

@Inhishonor Inhishonor marked this pull request as draft January 17, 2026 04:23

@Inhishonor Inhishonor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also run the ktlint with the format command and include those changes in a separate commit or pr, that way the CI won't keep failing on future commits.

Comment thread .github/workflows/build-on-pull.yml Outdated
Comment thread .github/workflows/build-on-pull.yml Outdated
Comment thread build.gradle
Comment thread .editorconfig Outdated
Comment thread .editorconfig Outdated
Comment thread presentation/build.gradle Outdated
@xmready xmready force-pushed the feature/ktlint-spotless branch 2 times, most recently from 4785640 to 7eb6894 Compare March 11, 2026 23:44
@xmready xmready requested a review from Inhishonor March 11, 2026 23:45
@xmready xmready force-pushed the feature/ktlint-spotless branch 5 times, most recently from 2a82d78 to 57bb0b3 Compare March 12, 2026 03:26
@xmready xmready force-pushed the feature/ktlint-spotless branch from 57bb0b3 to f4f02da Compare March 13, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants