New: lensIso#3465
Open
Harris-Miller wants to merge 5 commits into
Open
Conversation
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (929ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (943ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (870ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Coverage> ramda@0.30.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1190 passing (888ms)
=============================== Coverage summary ===============================
Statements : 94.04% ( 2477/2634 )
Branches : 85.73% ( 967/1128 )
Functions : 93.25% ( 553/593 )
Lines : 94.32% ( 2323/2463 )
================================================================================ |
Contributor
Author
Contributor
|
Can achieve the same with |
Contributor
Author
|
I didn't think to use Ref: https://tsplay.dev/WP2BJN The only reason I can see keeping this then would be for convenience and exposure. I can adjust the file to use |
Contributor
|
We have https://github.com/ramda/ramda-lens which feels like where it belongs. But of course that hasn't been updated in many years. I reckon mull it over for a bit and if you want to bring it in or others chime that they'd like it we can work to get it in. |
Coverage Summary> ramda@0.30.1 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1198 passing (1s)
=============================== Coverage summary ===============================
Statements : 94.07% ( 2490/2647 )
Branches : 85.75% ( 969/1130 )
Functions : 93.28% ( 555/595 )
Lines : 94.34% ( 2335/2475 )
================================================================================ |
Contributor
Author
|
I decided to finish it. Seems like it could be useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself having to implement this on my own recently in a project at work. It's useful to have alongside
lensand has a distinct implementation that isn't a simple composition of other functions. So figured it was worth adding to the core libTODO: