Fix toString cycle detection equality dispatch#3530
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
Coverage Summary> ramda@0.32.0 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register
�[2J�[1;3H
1209 passing (974ms)
=============================== Coverage summary ===============================
Statements : 94.1% ( 2519/2677 )
Branches : 85.9% ( 981/1142 )
Functions : 93.37% ( 563/603 )
Lines : 94.36% ( 2361/2502 )
================================================================================ |
kedashoe
approved these changes
Jun 15, 2026
kedashoe
left a comment
Contributor
There was a problem hiding this comment.
ty for the PR, looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toStringcircular-reference detectionequalsmethods while checking seen valuesFixes #3150.
Tests
BABEL_ENV=cjs npm exec -- mocha test/toString.js --require @babel/register --reporter spec --grep "does not dispatch to equals"BABEL_ENV=cjs npm exec -- mocha test/toString.js --require @babel/register --reporter minnpm run specnpm run lintgit diff --check