fix(dom): Hyperlinks are overridden when rendered after Paragraph#98
Open
Emivvvvv wants to merge 3 commits into
Open
fix(dom): Hyperlinks are overridden when rendered after Paragraph#98Emivvvvv wants to merge 3 commits into
Emivvvvv wants to merge 3 commits into
Conversation
orhun
reviewed
May 7, 2025
orhun
left a comment
Member
There was a problem hiding this comment.
This looks good, however I don't understand how this is currently fixing the issue.
It would be really nice if you can explain the problem and solution in detail. This might also lead to a cleaner solution :)
…rove documentation
Member
|
Thanks for the changes @Emivvvvv! Can you remind me how to test this again? Maybe we should update one of the existing examples to hit this case (so that it's clear that it works). What do you think? Also did this work for you locally for your website? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #97
This update refactors
update_gridto detect when a line’s hyperlink structure changes (hyperlink is added or removed) and triggers a full re-render of that line. A newrerender_linemethod rebuilds the DOM with correct anchor elements for hyperlink groups. If no hyperlink changes are detected, only the modified cells are updated as before.