Skip to content
This repository was archived by the owner on Jun 9, 2020. It is now read-only.

TST: Update test matrix#147

Open
pllim wants to merge 5 commits into
rkern:masterfrom
pllim:patch-3
Open

TST: Update test matrix#147
pllim wants to merge 5 commits into
rkern:masterfrom
pllim:patch-3

Conversation

@pllim

@pllim pllim commented Mar 20, 2019

Copy link
Copy Markdown
Contributor

It is chronically failing and Python 3.3 is rather old by now.

@jakirkham

jakirkham commented May 31, 2019

Copy link
Copy Markdown

I think it is also unsupported. Is someone able to review this PR?

@cclauss

cclauss commented Jul 12, 2019

Copy link
Copy Markdown

3.4 is EOL now too.

@cclauss

cclauss commented Jul 12, 2019

Copy link
Copy Markdown

Also see #162

@pllim

pllim commented Jul 12, 2019

Copy link
Copy Markdown
Contributor Author

Hah, @cclauss , looks like we are duplicating each other. I just updated this PR too. Anyway, I'll let the maintainers decide. I was just trying to help on the side and not really involved with this project.

@cclauss

cclauss commented Jul 12, 2019

Copy link
Copy Markdown

Same. It was a dependency on a project so I jumped in to see what the real story was. If you want to cherrypick the 3.7 and 3.8-dev stuff out of #162 and put them into this PR then I will gladly close #162.

@pllim

pllim commented Jul 12, 2019

Copy link
Copy Markdown
Contributor Author

@cclauss , I think in a way I already did, except that I am not allowing 3.7 to fail.

@pllim

pllim commented Jul 12, 2019

Copy link
Copy Markdown
Contributor Author

p.s. Yikes, it just failed, so maybe I'll have to.

@cclauss

cclauss commented Jul 12, 2019

Copy link
Copy Markdown

The problem is that very few maintainers pay a lot of attention or merge PRs that have failing tests. ;-)

@pllim pllim changed the title TST: Remove Python 3.3 from test matrix TST: Update test matrix Jul 12, 2019
@cclauss

cclauss commented Jul 12, 2019

Copy link
Copy Markdown

#153 or similar is required to be compatible with Python 3.7.

@pllim

pllim commented Jul 12, 2019

Copy link
Copy Markdown
Contributor Author

p.s. As far as your dependency tree is concerned, given that this PR has been open for 4 months, you might want to be in contact with the maintainers or maybe have someone from your company to volunteer to co-maintain this. Just a thought.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants