Skip to content

Don't emit application/octet-stream if we don't recognize the file#28

Merged
dinosaure merged 2 commits into
masterfrom
fix-mime-type
May 5, 2026
Merged

Don't emit application/octet-stream if we don't recognize the file#28
dinosaure merged 2 commits into
masterfrom
fix-mime-type

Conversation

@dinosaure

Copy link
Copy Markdown
Contributor

No description provided.

silene pushed a commit to silene/opam-repository that referenced this pull request Apr 16, 2026
CHANGES:

- Add `Vif.Queries.all` (@reynir, [robur-coop/vif#5][5])
- Improve examples and `README.md` (@dinosaure, @reynir, [robur-coop/vif#7][7], [robur-coop/vif#9][9])
- Rename `Vif.Uri.path` to `Vif.Uri.path` (@dinosaure, @reynir, [robur-coop/vif#8][8])
- Fix errors when we parse `multipart/form-data` (@dinosaure, spotted by @yomimono, [robur-coop/vif#14][14], [robur-coop/vif#22][22])
- Catch exceptions from URI converters (@reynir, @dinosaure, [robur-coop/vif#12][12])
- Add `?etag` argument for files (@reynir, [robur-coop/vif#16][16])
- Be able to have a regular expression per HTTP methods (@reynir, [robur-coop/vif#18][18])
- Add `Vif.Uri.execp` and `Vif.Uri.extract` (@reynir, [robur-coop/vif#20][20])
- Exclude `?` from ``Vif.Uri.string `Path`` (@reynir, [robur-coop/vif#23][23])
- Add `Vif.Response.with_text` (@dinosaure, [robur-coop/vif#24][24], [robur-coop/vif#37][37])
- Fix the support of MacOS (@vvvvv, @dinosaure, spotted by @voodoos, [robur-coop/vif#25][25])
- Introduce `vifu`, a unikernel compatible version of `vif` (@dinosaure, [robur-coop/vif#28][28])
- Fix `Vif.Response.with_file` (@dinosaure, [robur-coop/vif#29][29])
- Fix a double-close on `Vif.Response.with_json` and how the function is exposed (@dinosaure, [robur-coop/vif#30][30], [robur-coop/vif#37][37])
- Let the user to define a log reporter (@voodoos, @dinosaure, [robur-coop/vif#32][32])
- Fix the support of h2 protocol and which field we should generate (@dinosaure, [robur-coop/vif#33][33])
- Use [`flux`](https://github.com/robur-coop/flux) (@dinosaure, [robur-coop/vif#34][34])
- Fix memory leak with `logs` (@dinosaure, [robur-coop/vif#38][38], [robur-coop/vif#39][39])
- Update to `tyre.1.0.0` (@dinosaure, @EmileTrotignon, [robur-coop/vif#40][40])
- Remove the usage of ppx in our tests (@dinosaure, [robur-coop/vif#42][42])
- Verify the TLS configuration given (and its ALPN protocols) (@dinosaure, spotted by @voodoos, [robur-coop/vif#41][41])
- Provide `Vif.Response.with_stream` (@dinosaure, [robur-coop/vif#43][43])
- Remove deprecated `jsonm` dependency (@dinosaure, [robur-coop/vif#45][45])
- Give the possibility for the user to initialize RNG (@dinosaure, requested by @voodoos, [robur-coop/vif#46][46])
- Remove pin-depends (@hannesm, @dinosaure, [robur-coop/vif#48][48])

[5]: https://git.robur.coop/robur/vif/pulls/5
[7]: https://git.robur.coop/robur/vif/pulls/7
[9]: https://git.robur.coop/robur/vif/pulls/9
[8]: https://git.robur.coop/robur/vif/pulls/8
[14]: https://git.robur.coop/robur/vif/pulls/14
[22]: https://git.robur.coop/robur/vif/pulls/22
[12]: https://git.robur.coop/robur/vif/pulls/12
[16]: https://git.robur.coop/robur/vif/pulls/16
[18]: https://git.robur.coop/robur/vif/pulls/18
[20]: https://git.robur.coop/robur/vif/pulls/20
[23]: https://git.robur.coop/robur/vif/pulls/23
[24]: https://git.robur.coop/robur/vif/pulls/24
[37]: https://git.robur.coop/robur/vif/pulls/37
[25]: https://git.robur.coop/robur/vif/pulls/25
[28]: https://git.robur.coop/robur/vif/pulls/28
[29]: https://git.robur.coop/robur/vif/pulls/29
[30]: https://git.robur.coop/robur/vif/pulls/30
[37]: https://git.robur.coop/robur/vif/pulls/37
[32]: https://git.robur.coop/robur/vif/pulls/32
[33]: https://git.robur.coop/robur/vif/pulls/33
[34]: https://git.robur.coop/robur/vif/pulls/34
[38]: https://git.robur.coop/robur/vif/pulls/38
[39]: https://git.robur.coop/robur/vif/pulls/39
[40]: https://git.robur.coop/robur/vif/pulls/40
[42]: https://git.robur.coop/robur/vif/pulls/42
[41]: https://git.robur.coop/robur/vif/pulls/41
[43]: https://git.robur.coop/robur/vif/pulls/43
[45]: https://git.robur.coop/robur/vif/pulls/45
[46]: https://git.robur.coop/robur/vif/pulls/46
[48]: https://git.robur.coop/robur/vif/pulls/48
voodoos pushed a commit to voodoos/vif that referenced this pull request May 2, 2026
@dinosaure dinosaure merged commit 47504f8 into master May 5, 2026
4 of 5 checks passed
@dinosaure dinosaure deleted the fix-mime-type branch May 5, 2026 19:36
@dinosaure dinosaure restored the fix-mime-type branch May 6, 2026 01:22
hannesm pushed a commit to ocaml/opam-repository that referenced this pull request May 10, 2026
CHANGES:

- Delete `mirage-crypto-rng-miou-unix` dependency for `vif.core`\
  (@dinosaure, 3fb86c5)
- Improve performances, when we handle requests without body, we executed them
  directly instead of transferring the handler into a new domain
  (@dinosaure, robur-coop/vif#25, [!51][51])
- Catch exceptions raised by `jsont` (@dinosaure, [!52][52])
- Use `jws` instead of `jwto` (@dinosaure, [!53][53])
- Handle TLS flow with `vifu` (@dinosaure, [!54][54])
- Expose `Vifu.Uri.{execp,extract}` (@swrup, robur-coop/vif#26)
- Use `Flux.Source.with_buffered_formatter` (instead of `with_formatter`)
  (@reynir, [!55][55])
- Fix the compilation with `caqti.2.3.0` (@dinosaure, [!57][57])
- Get ride of `rresult` (@reynir, [!58][58])
- Depends on `flux.0.0.1~beta5` (@reynir, [!59][59])
- Be able to stop a Vif server (as we do for `httpcats`)
  (@theAlexes, @dinosaure, robur-coop/vif#29)
- Be able to specify a UNIX domain socket as our listener for our webserver
  (@theAlexes, @dinosaure, @reynir, robur-coop/vif#30, robur-coop/vif#31)
- Use `httpcats.0.3.0` and shutdown our connection at the end
  (@dinosaure, [!60][60])
- Add `OPTIONS` method for our routes (@voodoos, robur-coop/vif#33)
- Revert [!60][60] and fix unexpected closed connection (see robur-coop/vif#32) and when we
  would like to transmit big file ([!61][61], spotted by @voodoos, @dinosaure,
  @theAlexes)
- Don't emit `application/octet-stream` for unrecognized files
  (spotted by @n-osborne, @dinosaure, robur-coop/vif#27, robur-coop/vif#28)

[51]: https://git.robur.coop/robur/vif/pulls/51
[52]: https://git.robur.coop/robur/vif/pulls/52
[53]: https://git.robur.coop/robur/vif/pulls/53
[54]: https://git.robur.coop/robur/vif/pulls/54
[55]: https://git.robur.coop/robur/vif/pulls/55
[57]: https://git.robur.coop/robur/vif/pulls/57
[58]: https://git.robur.coop/robur/vif/pulls/58
[59]: https://git.robur.coop/robur/vif/pulls/59
[60]: https://git.robur.coop/robur/vif/pulls/60
[61]: https://git.robur.coop/robur/vif/pulls/61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant