[codex] test: cover threaded fusion regressions#27
Closed
siyul-park wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 55.77% 55.89% +0.11%
==========================================
Files 48 48
Lines 7659 7659
==========================================
+ Hits 4272 4281 +9
+ Misses 2949 2942 -7
+ Partials 438 436 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LOCAL_GET+I32_CONST+I32_ADDthroughCALL/RETURNininterp/threaded.go.LOCAL_GET+I32_CONST+I32_DIV_Sand verifiesErrDivideByZerostill propagates.Why
Recent interpreter changes introduced threaded fusion for numeric
LOCAL_GETand constant producers ininterp/threaded.go. These paths were changed recently but were not pinned by a focused test around callee return flow or fused arithmetic error propagation.Changed paths tested
interp/threaded.go: fused numericLOCAL_GETpathinterp/threaded.go: fused arithmetic onI32_CONSTproducersinterp/interp.go: cached current-frame behavior exercised via call/return executionValidation
go test -race ./interpSkipped targets
interp/jit.gocutoff/closure updates: existing nearby JIT tests already cover emission/link behavior, and adding more would require architecture-specific setup beyond this narrow diff.LOCAL_GETnon-fusion path: the recent change explicitly preserves the threaded fallback for refs, but there was no equally small new regression case with stronger signal than the numeric fusion tests added here.