Skip to content

test: recent map edge cases#31

Merged
siyul-park merged 1 commit into
mainfrom
codex/test-gap-detection-map-tests
May 21, 2026
Merged

test: recent map edge cases#31
siyul-park merged 1 commit into
mainfrom
codex/test-gap-detection-map-tests

Conversation

@siyul-park

Copy link
Copy Markdown
Owner

Summary

  • add interpreter regression coverage for recent map runtime edge cases
  • add parser coverage for nested and invalid map[...] type syntax

Changed paths tested

  • interp/map.go / interp/threaded.go
  • types/parse.go

Added tests

  • MAP_GET returns the same entry for -0.0 and 0.0 float keys
  • MAP_NEW keeps the last value when duplicate keys are provided
  • types.Parse handles nested bracketed map keys and rejects missing key/elem map syntax

Validation

  • go test ./types
  • go test ./interp

Skipped targets

  • map ref/string retain-release branches: behavior is clear but would require heap-lifetime assertions with higher setup cost than this narrow coverage task
  • docs and opcode metadata files: already exercised indirectly by existing type/opcode tests and not a behavior gap for this change

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.94%. Comparing base (df4ac91) to head (0330d85).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   52.77%   52.94%   +0.16%     
==========================================
  Files          51       51              
  Lines        8887     8887              
==========================================
+ Hits         4690     4705      +15     
+ Misses       3657     3646      -11     
+ Partials      540      536       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siyul-park siyul-park marked this pull request as ready for review May 21, 2026 13:28
@siyul-park siyul-park changed the title [codex] test recent map edge cases test: recent map edge cases May 21, 2026
@siyul-park siyul-park merged commit 9b1731c into main May 21, 2026
5 checks passed
@siyul-park siyul-park deleted the codex/test-gap-detection-map-tests branch May 22, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant