perf: optimize heap opcode paths#37
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 53.84% 54.01% +0.17%
==========================================
Files 58 57 -1
Lines 9867 10067 +200
==========================================
+ Hits 5313 5438 +125
- Misses 3930 3978 +48
- Partials 624 651 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapType.types.Fielded; struct opcodes now handle native*types.Structdirectly and fall back to concreteHostObjecthandling.Impact
Heap-heavy interpreter opcodes for strings, arrays, structs, and maps avoid extra rooting, interface dispatch, and generic map handling on common hot paths.
MapTypemetadata is now public cached state populated by constructors.Validation
go test ./types ./interpgo test ./...go test -race ./interp ./typesmake lintgit diff --checkgo test -run '^$' -bench 'BenchmarkInterpreter_Run/default/.*(string|array|struct|map)' -benchmem -benchtime=300ms ./interp