Skip to content

[codex] add interp regression coverage for recent marshaling changes #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siyul-park merged 1 commit into from
May 26, 2026
Merged

[codex] add interp regression coverage for recent marshaling changes #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 44 additions & 6 deletions interp/interp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2204,14 +2204,34 @@ func TestInterpreter_Len(t *testing.T) {
}

func TestInterpreter_Alloc(t *testing.T) {
i := New(program.New(nil))
defer i.Close()
t.Run("basic", func(t *testing.T) {
i := New(program.New(nil))
defer i.Close()

for _, v := range []types.Value{types.I32(7), types.BoxI32(3)} {
addr, err := i.Alloc(v)
require.NoError(t, err)
require.Greater(t, addr, 0)
}
})

t.Run("interns strings", func(t *testing.T) {
i := New(program.New(nil))
defer i.Close()

for _, v := range []types.Value{types.I32(7), types.BoxI32(3)} {
addr, err := i.Alloc(v)
first, err := i.Alloc(types.String("same"))
require.NoError(t, err)
require.Greater(t, addr, 0)
}
second, err := i.Alloc(types.String("same"))
require.NoError(t, err)
require.Equal(t, first, second)
require.Equal(t, 2, i.rc[first])

require.NoError(t, i.Release(first))
require.Contains(t, i.interned, "same")

require.NoError(t, i.Release(second))
require.NotContains(t, i.interned, "same")
})
}

func TestInterpreter_Load(t *testing.T) {
Expand Down Expand Up @@ -3831,6 +3851,24 @@ func TestInterpreter_Unmarshal(t *testing.T) {
require.Equal(t, int32(4), *out)
})

t.Run("host object pointer target", func(t *testing.T) {
i := New(program.New(nil))
defer i.Close()

id := hostUserID(41)
got, err := i.Marshal(&id)
require.NoError(t, err)

ho, ok := got.(*HostObject)
require.True(t, ok)
ho.SetField(0, types.BoxI64(99))

var out *hostUserID
require.NoError(t, i.Unmarshal(got, &out))
require.NotNil(t, out)
require.Equal(t, hostUserID(99), *out)
})

t.Run("value target", func(t *testing.T) {
i := New(program.New(nil))
defer i.Close()
Expand Down
Loading