[codex] test nested return frame restore#44
Merged
Conversation
8579b1a to
a8e74e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a focused interpreter regression test for nested function returns in
/Users/siyulpark/.codex/worktrees/d9b2/minivm/interp/interp_test.go.The new case exercises a recent
interp/threaded.gochange that replaced repeatedframes[fp-1]lookups with the cached current-frame pointeri.fr. It verifies that after an inner function returns, the caller frame is restored before the caller executesLOCAL_SETandLOCAL_GET.Changed paths tested
interp/threaded.go:CALL/RETURNframe restoration through subsequent caller-local accessinterp/interp_test.go: addednested return restores caller frame for localsValidation
go test ./interp -run 'TestInterpreter_Run/nested return restores caller frame for locals'go test ./interp -run 'TestInterpreter_Run|TestInterpreter_WithThreshold'Skipped targets
interp/threaded.go: skipped because the recent refactor mostly changed frame-pointer access patterns, and existing table-driven runtime coverage already exercises many opcodes.