Add algorithm include for std::find_if, min, and max#1360
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds missing standard library includes so compilation succeeds when <algorithm> isn’t transitively included (e.g., for std::find_if / std::none_of usage) across several TagLib components.
Changes:
- Include
<algorithm>in multiple.cppfiles that use<algorithm>facilities (std::find_if,std::none_of). - Minor include-block formatting adjustments in some Matroska sources to keep local/system includes visually separated.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
taglib/tagunion.cpp |
Adds <algorithm> for std::find_if / std::none_of usage. |
taglib/mpeg/id3v2/frames/textidentificationframe.cpp |
Adds <algorithm> for std::find_if usage. |
taglib/mp4/mp4atom.cpp |
Adds <algorithm> for std::none_of / std::find_if usage. |
taglib/matroska/matroskatag.cpp |
Keeps <algorithm> include and adjusts spacing around include groups. |
taglib/matroska/matroskaseekhead.cpp |
Adds <algorithm> for std::find_if usage and separates include groups. |
taglib/matroska/matroskachapters.cpp |
Adds <algorithm> for std::find_if usage and separates include groups. |
taglib/matroska/matroskaattachments.cpp |
Adds <algorithm> for std::find_if usage and separates include groups. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
algorithm include for std::find_ifalgorithm include for std::find_if, min, and max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.